History backfill rate limiter #8645
Open
+69
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added rate limiting for persistence calls for history replication system. Set this high enough not to limit us by default.
Why?
This allows us to limit the impact of large replicated workflow histories on the persistence layer.
How did you test it?
Note
Introduce dynamic-configured persistence QPS limiter for history replication and backfill, wired through FX and enforced in replicator methods.
history.ReplicationTaskProcessorApplyPersistenceQPSand expose viaconfigs.Config.PersistenceRateLimiterand provider (replication/quotas.go), registered inreplication/fx.Module.history_engine.go, factory) and pass tondc.NewHistoryReplicator.HistoryReplicatorImplto use the limiter (Wait) inApplyEvents,BackfillHistoryEvents, andReplicateHistoryEvents.Written by Cursor Bugbot for commit 26deef2. This will update automatically on new commits. Configure here.